protocols/kad: Refactor KademliaEvent #2297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored InboundPutRecordRequest to InboundRequest::PutRecord - Refactored InboundAddProviderRequest to InboundRequest::AddProvider - Refactored KademliaEvent::InboundRequestServed to KademliaEvent::InboundRequest Signed-off-by: supercmmetry <vishaals2000@gmail.com>
- Remove doclink for InboundPutRecordRequest - Remove doclink for InboundAddProviderRequest Signed-off-by: supercmmetry <vishaals2000@gmail.com>
mxinden
reviewed
Oct 19, 2021
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
A couple of comments, mostly on the documentation side. Thanks for looking into this.
Signed-off-by: supercmmetry <vishaals2000@gmail.com>
supercmmetry
force-pushed
the
fix/2283
branch
from
6446249 to
b7a371b
Compare
Signed-off-by: supercmmetry <vishaals2000@gmail.com>
Contributor
Author
|
@mxinden can you check if there is anything else you need? |
Member
|
Merged via #2321. Thanks @supercmmetry for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InboundPutRecordRequesttoInboundRequest::PutRecordInboundAddProviderRequesttoInboundRequest::AddProviderKademliaEvent::InboundRequestServedtoKademliaEvent::InboundRequestCloses #2283