Skip to content

Conversation

@mxinden
Copy link
Member

@mxinden mxinden commented Apr 12, 2021

I would like to cut libp2p v0.37.0. Any objections? Anything you would like to see included which is not in master today?

I would suggest releasing #2043 as a separate bug-fix release.

@mxinden mxinden merged commit 42441db into libp2p:master Apr 13, 2021
@mxinden
Copy link
Member Author

mxinden commented Apr 13, 2021

Published and tagged the following crates:

  • libp2p-core-0.28.2
  • libp2p-floodsub-0.29.0
  • libp2p-gossipsub-0.30.0
  • libp2p-identify-0.29.0
  • libp2p-kad-0.30.0
  • libp2p-mdns-0.30.0
  • libp2p-ping-0.29.0
  • libp2p-relay-0.2.0
  • libp2p-request-response-0.11.0
  • libp2p-swarm-0.29.0
  • libp2p-yamux-0.32.0
  • v0.37.0

Note with the resolver = "2" option introduced in #2038 one needs to use cargo > 1.51. See rust-lang/cargo#9337 for details. (//CC @tomaka for Substrate since you are using resolver v2 as well.)

@dvc94ch
Copy link
Contributor

dvc94ch commented Apr 13, 2021

You forgot to release swarm-derive

@dvc94ch
Copy link
Contributor

dvc94ch commented Apr 13, 2021

cargo really needs better support for releasing workspaces. I haven't tried the parity tool yet, maybe cargo-unleash is something that could help.

@mxinden
Copy link
Member Author

mxinden commented Apr 13, 2021

You forgot to release swarm-derive

Good catch @dvc94ch! Thanks. I missed the version bump in bb206bc. I am not an owner of libp2p-swarm-derive on crates.io. I yanked libp2p v0.37.0 for now. I will publish libp2p-swarm-derive v0.23.0 and libp2p v0.37.1 once I have access.

@dvc94ch
Copy link
Contributor

dvc94ch commented Apr 13, 2021

Please no yanking, I hope you can just release 0.37.1 with the derive macro, I already published two crates using 0.37.0

@mxinden
Copy link
Member Author

mxinden commented Apr 13, 2021

Sorry for the inconvenience but I already yanked v0.37.0 to prevent others from running into the same issue, as many rust-libp2p users use the derive macro.

@mxinden
Copy link
Member Author

mxinden commented Apr 14, 2021

I will publish libp2p-swarm-derive v0.23.0 and libp2p v0.37.1 once I have access.

libp2p-swarm-derive v0.23.0 and libp2p v0.37.1 have been tagged and published.

Thanks @romanb for the help.

elenaf9 pushed a commit to elenaf9/rust-libp2p that referenced this pull request Apr 16, 2021
AgeManning pushed a commit to sigp/rust-libp2p that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants