chore(@libp2p/multidim-interop): remove webrtc support temp #2006
Closed
maschad wants to merge 2 commits intolibp2p:masterfrom
Closed
chore(@libp2p/multidim-interop): remove webrtc support temp #2006maschad wants to merge 2 commits intolibp2p:masterfrom
maschad wants to merge 2 commits intolibp2p:masterfrom
Conversation
This was referenced Aug 30, 2023
Member
|
From what I can see in libp2p/test-plans#279 the failure was caused by not having cmake installed on the build machine. This has been fixed here though it looks like that PR is still open. When cmake is installed as per the linked patch, is this still a problem? |
Member
Author
the attempt to install |
Member
|
Re: the cmake installation failure: https://github.com/libp2p/test-plans/pull/286/files#r1310029825 Is it still a problem? |
Member
Author
|
Closing as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are not currently testing webRTC in multidim-interop (see #1846) this removes the dependency so that this package doesn't require it, as it's third party dependency nodechannels causes build failures on some environments (see libp2p/test-plans#279)
Whilst that build issue should be resolved, the multidim interop should require dependent to be built which are unused so this seeks to resolve that until the webRTC tests are re-introduced.
Related to #2005