This repository was archived by the owner on Jul 21, 2023. It is now read-only.
refactor: async await #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Switch to using async/await and async iterators.
dirkmc
approved these changes
Nov 8, 2019
Contributor
dirkmc
left a comment
dirkmc
left a comment
There was a problem hiding this comment.
Nice work Vasco
Left a few nits but otherwise LGTM 👍
vasco-santos
force-pushed
the
refactor/async-await
branch
6 times, most recently
from
767110f to
52d056e
Compare
vasco-santos
force-pushed
the
refactor/async-await
branch
from
52d056e to
76a872f
Compare
Member
Author
|
@dirkmc can you have a new pass? We decided to make this change in two different PRs. The first one (this) to move everything to async await, followed by a new one to move |
Member
Author
|
I felt the dht code structure was getting in a point that it was really difficult to maintain. Therefore, I decided to restructure the file structure in order to ease maintainability and new contributions |
dirkmc
approved these changes
Nov 18, 2019
jacobheun
reviewed
Nov 19, 2019
Contributor
jacobheun
left a comment
jacobheun
left a comment
There was a problem hiding this comment.
Just a few suggestions and a couple questions about TODOs, but otherwise this looks good.
Co-Authored-By: Jacob Heun <[email protected]>
vasco-santos
force-pushed
the
refactor/async-await
branch
from
6de323d to
ba96e12
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of ipfs/js-ipfs#1670 all the API is moving into async
BREAKING CHANGE: Switch to using async/await and async iterators.