feat(perf_buffer): perf_buffer relies on traits rather than specific type#939
Merged
d-e-s-o merged 1 commit intolibbpf:masterfrom Sep 18, 2024
Merged
Conversation
CoderPoet
force-pushed
the
feat/pinning-map-support
branch
5 times, most recently
from
1f975ad to
f4c6b42
Compare
CoderPoet
force-pushed
the
feat/pinning-map-support
branch
from
f4c6b42 to
60bb0f0
Compare
d-e-s-o
approved these changes
Sep 18, 2024
Collaborator
d-e-s-o
left a comment
d-e-s-o
left a comment
There was a problem hiding this comment.
Seems fine to me, thanks!
d-e-s-o
added a commit
to d-e-s-o/libbpf-rs
that referenced
this pull request
Sep 20, 2024
Add a CHANGELOG entry for pull request libbpf#939, which adjusted the PerfBufferBuilder type to work with anything implementing the MapCore trait instead of strictly requiring a Map object. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
added a commit
that referenced
this pull request
Sep 20, 2024
Add a CHANGELOG entry for pull request #939, which adjusted the PerfBufferBuilder type to work with anything implementing the MapCore trait instead of strictly requiring a Map object. Signed-off-by: Daniel Müller <deso@posteo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement
This PR introduces a flexible and generic implementation for
PerfBufferBuilderto support any type that implements theMapCoreandAsFdtraits, rather than being restricted to a specificMaptype.Why This Change is Needed:
Currently,
PerfBufferBuilderis limited to a specificMaptype, which restricts its usability with other types that implement the required traits. This update increases the extensibility of thePerfBufferBuilderand allows developers to use it with a wider variety of map-like structures. For example, a scenario that uses a pinning map.