Buffer refactor and buffer bug fixes #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2022
TheOneric
force-pushed
the
buffer_refactor
branch
from
e79d790 to
de7abd2
Compare
TheOneric
changed the title
TheOneric
changed the title
Cherry-picked from: jellyfin@6d3a5c7 [part of] Restructure renderBlend so it can return multiple pieces; JS side not ready yet Cherry-picked from: jellyfin@0cc2bf8 Move private members to the top. Renamed take to get_rawbuf for clarity.
malloc and realloc may both return NULL in absence of errors if the size is 0. Additionally realloc acts as a free in this case, meaning the later `return NULL;` will leave dangling pointers in the object.
This allows to conveniently protect against size overflows inside the ensure_size method.
Supposedly later jellyfin patches won't always need zero-initialised memory, so we can't just do this unconditionally. I doubt this is in any relevant way faster than an external memset, but there was a strong push against redoing the multiplication or just zeroing the actual capacity.
TheOneric
force-pushed
the
buffer_refactor
branch
from
de7abd2 to
1e9d5cd
Compare
Member
Author
|
If anyone wants to take a closer look at this, write so now. If no one requests more time or objects, I'll merge this in about 2 days. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor into a class is part of the jellyfin backports and here followed up by various bug fixes. The class members have been refactored for clarity and unused functions dropped.
As I mentioned in #120, checking the size on each frame rather than only on resizes is somewhat superfluous now (but already what happened before this change) but apparently the "smart-blend" changes will require resizes on each frame. Let’s wait until those patches come in to see if this can be improved upon.