Fix: support subproject repos in info-yaml validation#559
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the reusable GitHub Actions workflow that validates INFO.yaml for Gerrit-triggered changes, adding support for Gerrit project names that include subpaths (subproject repos) while INFO.yaml lists only the parent project.
Changes:
- Extend repository validation to accept either an exact match or a parent-prefix match (e.g.,
integrationvalidatingintegration/distribution). - Improve inline documentation around the repository validation logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
The repository comparison in info-yaml-verify fails for repos with subproject structure (e.g. integration/distribution, releng/builder, releng/autorelease) where INFO.yaml lists the parent project name (e.g. 'integration') but GERRIT_PROJECT is the full path (e.g. 'integration/distribution'). Add a prefix match so that 'integration' matches 'integration/distribution' while still requiring exact match for standard repos. Issue: IT-29437 Change-Id: I2592ee937f341ec989768350fcb8bd12ead8e83e Signed-off-by: Anil Belur <[email protected]>
9cb9f5e to
c16cf9b
Compare
tykeal
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The info-yaml-verify workflow fails for repositories with subproject structure where the Gerrit project name includes a subpath (e.g.
integration/distribution,releng/builder,releng/autorelease).The
INFO.yamlin these repos lists the parent project name (e.g.integration), butGERRIT_PROJECTpasses the full path (e.g.integration/distribution). The strict equality check fails:Fix
Add a prefix match alongside the exact match so that
integrationvalidates againstintegration/distribution:This handles:
netconf==netconf✅ (exact match)integrationprefix ofintegration/distribution✅ (prefix match)Affected Repositories
integration/distribution— https://github.com/opendaylight/integration-distribution/actions/runs/23285321556releng/builderreleng/autoreleaseTesting
The fix was verified against the failing CI runs for
integration/distribution.Signed-off-by: Anil Belur [email protected]