Add conversion to SystemTime within ReactionCtx#49
Open
Conversation
cmnrd
approved these changes
Jun 3, 2024
Contributor
cmnrd
left a comment
cmnrd
left a comment
There was a problem hiding this comment.
Looks good! But it looks like clippy isn't happy with the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So with @AneesHl and @cmnrd we talked about replacing the use of Instant with SystemTime within the runtime. One problem of Instant is it is opaque, although it can easily be turned into a Duration (from program startup). With SystemTime we would have a Duration since the Unix Epoch, which helps in the short term with LF-Rust/LF-C interop, and in the long term, maybe with federated execution.
Instead of replacing Instant completely though, I wonder if the following changeset would also do the trick. This just adds a conversion function from Instant to SystemTime using a reference point taken at the startup of the program. The runtime otherwise still uses Instant internally, which is nice because it is monotonic.