Conversation
erlingrj
force-pushed
the
rs-runtime-version
branch
from
a217438 to
c38151c
Compare
erlingrj
requested changes
Feb 3, 2025
Collaborator
erlingrj
left a comment
erlingrj
left a comment
There was a problem hiding this comment.
The commit hash in runtime-version.properties must match the commit hash of the reactor-rs submodule!
Jakio815
force-pushed
the
rs-runtime-version
branch
from
f7f4503 to
c38151c
Compare
Collaborator
Author
|
@erlingrj Thanks for checking. Why don't we also merge lf-lang/reactor-rs#50? |
Collaborator
|
It was now just merged. Could you update the submodule pointer and then run |
erlingrj
approved these changes
Feb 6, 2025
Collaborator
erlingrj
left a comment
erlingrj
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update rust runtime version.