Remove the "netaccess" container from the docker-compose dev environment. #7123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds extra complexity around the docker use here. Verifying vendor and govulncheck can be done outside of the dev docker container.
mcpherrinm
force-pushed
the
mattm-no-netaccess
branch
from
0aabd04 to
d9f14e0
Compare
Contributor
|
This makes sense to me. |
This enables the -e and -o pipefail bash-specific flags so that intermediate command failures will fail the step https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
mcpherrinm
changed the title
Contributor
Author
|
I pushed (and reverted) a few deliberately bad commits to make sure the vendoring and tidy checks failed as expected. |
aarongable
approved these changes
Oct 30, 2023
jsha
approved these changes
Nov 1, 2023
Contributor
|
Thanks for the improvements! |
pgporada
pushed a commit
that referenced
this pull request
Nov 13, 2023
Having govulncheck prevent a PR from merging means that circumstances entirely outside our control can grind Boulder development to a halt until they are addressed. When the vulnerability is within Go itself, it prevents PRs from being merged until we do a production deploy, because we want our CI to always match what is in production. This is too strict. This PR removes govulncheck from the set of jobs depended upon by our Boulder CI Test Matrix meta-job. It also adds vendorcheck, which was accidentally omitted in #7123.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the "netaccess" container from the docker-compose dev environment.
It isn't needed during a regular 'docker compose up' developer environment, and only really serves as a way to use the same tools image in CI. Two checks run during CI are the govulncheck and verifying go mod tidy / go vendor. Neither of these checks require anything from the custom image other than Golang itself, which can be provided directly from the CI environment.
If a developer is working inside the existing containers, they can still run
go mod tidy; go mod vendorthemselves, which is a standard Golang workflow and thus is simpler than using the netaccess image via docker compose.