feat(controls): Add Smooth Scrolling for Page and fix CardExpander has inconsistent CornerRadius
#1539
+382
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To split the corner radius
Use CornerRadiusSplitConverter for CardExpander
github-actions
bot
added
controls
Eliminate redundant declarations
- Added class SmoothScrollBehavior.cs - Apply SmoothScrollBehavior for DynamicScrollViewer.xaml
maihcx
changed the title
Contributor
Author
|
@Nuklon also check about this |
Removed CornerRadius template binding from Border.
Removed corner radius from ContentPresenterBorder and ToggleButtonBorder.
pomianowski
changed the title
CardExpander has inconsistent CornerRadius and Smooth Scrolling for Page
pomianowski
changed the title
CardExpander has inconsistent CornerRadius and Smooth Scrolling for PageCardExpander has inconsistent CornerRadius
Updated the CardExpander.xaml file by reordering and modifying namespaces, adjusting control templates, and refining trigger actions for better functionality and maintainability.
Collaborator
|
Please split this up in two PRs. I'm not sure if we should enable smooth scrolling by default. |
Contributor
Author
|
I will split it into 2 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #1538, #1546
What is the new behavior?
Fix CardExpander has inconsistent CornerRadius when opened and closed