Allow passing multiple resources when using resource options #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonelgalan
reviewed
Mar 9, 2020
Owner
leonelgalan
left a comment
leonelgalan
left a comment
There was a problem hiding this comment.
Sorry for the late review, I'm hoping the new Github Inbox, make sit less likely that I would dismiss important notifications.
Thanks for your contribution!
| end | ||
|
|
||
| def self.build_resources(resource, conditions) | ||
| [ resource ].flatten.map do |r| |
Owner
There was a problem hiding this comment.
We could change [resource].flatten to Array(resource).
Comment on lines
+90
to
+98
| With multiple resources | ||
|
|
||
| ```ruby | ||
| url = Aws::CF::Signer.sign_url 'http://d604721fxaaqy9.cloudfront.net/training/orientation.avi', | ||
| expires: 'Sat, 14 Nov 2009 22:20:00 GMT', | ||
| resource: [ 'http://d604721fxaaqy9.cloudfront.net/training/*', 'http://d604721fxaaqy9.cloudfront.net/lessons/*' ], | ||
| ip_range: '145.168.143.0/24' | ||
| ``` | ||
|
|
Owner
There was a problem hiding this comment.
What's the use case here?
Why not http://d604721fxaaqy9.cloudfront.net/*?
In "Creating a Policy Statement for a Signed URL That Uses a Custom Policy", it says:
Note the following:
- You can include only one statement.
| end | ||
| end | ||
|
|
||
| def self.build_resources(resource, conditions) |
Owner
There was a problem hiding this comment.
Don't you think build_statements would be a more appropriate name? It seem you are building an array of statements, all with Resource and Condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.