Skip to content

Chore: Improve CI speed #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lekemula merged 5 commits into from
Sep 20, 2025
Merged

Chore: Improve CI speed #23

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b07bb9d
Cache typechecking gems
lekemula Sep 20, 2025
c9c17ad
Cache YARD ans RBS when typechecking
lekemula Sep 20, 2025
2a3e8de
Cache YARD ans RBS when running tests
lekemula Sep 20, 2025
c87b0f4
Make BUNDLE_PATH a env
lekemula Sep 20, 2025
cbff1b0
Remove redundante ENV setting
lekemula Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.4
bundler-cache: false
bundler-cache: true # runs bundle install and caches the gems
- name: Install gems
run: |
bundle install
bundle update solargraph # use the latest version of solargraph
bundle update rbs # use latest available for this Ruby version
Comment on lines 35 to 43
Copy link

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With bundler-cache: true enabled, the setup-ruby action automatically runs bundle install. The subsequent bundle update commands may conflict with the cached dependencies, potentially causing version inconsistencies. Consider either disabling bundler-cache or restructuring the gem installation to avoid conflicts between cached and updated gems.

Copilot uses AI. Check for mistakes.
- name: Install gem types
run: bundle exec rbs collection install
Expand Down
Loading