Chore: Adjust specs/CI for next solargraph release after 0.56.2 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekemula
force-pushed
the
prepare-next-solargraph-release
branch
from
c012196 to
86e09e9
Compare
lekemula
force-pushed
the
prepare-next-solargraph-release
branch
from
86e09e9 to
454c62c
Compare
lekemula
force-pushed
the
prepare-next-solargraph-release
branch
5 times, most recently
from
7d07bb3 to
b62e1e2
Compare
lekemula
force-pushed
the
prepare-next-solargraph-release
branch
5 times, most recently
from
d2d9b08 to
2a83fdd
Compare
lekemula
force-pushed
the
prepare-next-solargraph-release
branch
2 times, most recently
from
eaaccaf to
bfe744d
Compare
lekemula
force-pushed
the
prepare-next-solargraph-release
branch
9 times, most recently
from
b383e57 to
82e18b5
Compare
lekemula
force-pushed
the
prepare-next-solargraph-release
branch
5 times, most recently
from
a01cec4 to
d188842
Compare
lekemula
force-pushed
the
prepare-next-solargraph-release
branch
from
d188842 to
bd9a022
Compare
lekemula
changed the title
lekemula
force-pushed
the
prepare-next-solargraph-release
branch
from
bd9a022 to
1cfac16
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the codebase for the next solargraph release after 0.56.2, focusing on spec maintenance and strict typechecking improvements.
- Updates test expectations and removes pending tests that are now working
- Fixes gem dependencies and adds type annotations for strict typechecking
- Improves CI workflow configuration and removes unused error handling
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/solargraph/rspec/convention_spec.rb | Updates test expectations with proper namespacing and removes pending test markers |
| lib/solargraph/rspec/test_helpers.rb | Fixes gem dependency lists for proper RSpec plugin detection |
| lib/solargraph/rspec/spec_walker/fake_let_method.rb | Removes unused error handling for syntax errors |
| lib/solargraph/rspec/config.rb | Adds type annotations for strict typechecking compliance |
| gemfiles/default.gemfile | Adds development dependencies including RBS and rubocop-yard |
| Appraisals | Adds net-imap version constraint to fix YARD compatibility |
| .solargraph.yml.example | Adds example configuration file for the project |
| .rubocop.yml | Consolidates exclusion patterns under AllCops section |
| .github/workflows/ruby.yml | Streamlines CI workflow by removing unnecessary path specifications |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| expect(completion_at(filename, [15, 13])).to include('host') # request.host | ||
| expect(completion_at(filename, [16, 5])).to include('response') | ||
| expect(completion_at(filename, [17, 14])).to include('body') # response.body | ||
| # The below expecattion does not work anymore because ActionDispatch::Response conflicts with Airborne#response |
There was a problem hiding this comment.
There's a typo in the comment: 'expecattion' should be 'expectation'.
Suggested change
| # The below expecattion does not work anymore because ActionDispatch::Response conflicts with Airborne#response | |
| # The below expectation does not work anymore because ActionDispatch::Response conflicts with Airborne#response |
| end | ||
|
|
||
| it 'completes mailer methods' do | ||
| pending("FIXME: Why it doesn't work?") |
There was a problem hiding this comment.
The pending test with 'FIXME' comment should either be fixed or have a more descriptive reason for being pending. Consider creating a GitHub issue and referencing it here.
Suggested change
| pending("FIXME: Why it doesn't work?") | |
| pending("Pending: Mailer method completion is not working as expected. See https://github.com/your-org/your-repo/issues/123 for details.") |
Owner
Author
|
Solargraph v0.57.0 has been released, fixing RSpec 3rd part plugins 🎉 |
lekemula
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparations for the next solargraph release Release 0.56.2