Skip to content

Conversation

@lekemula
Copy link
Owner

@lekemula lekemula commented Sep 6, 2025

[ERROR][2025-09-05 14:24:44] ...p/_transport.lua:36 "rpc" "solargraph"
"stderr" "[WARN] [RSpec] Error processing
/Users/lekemula/Projects/solargraph/spec/diagnostics/rubocop_helpers_spec.rb:
undefined method type' for
nil\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker/rspec_context_namespace.rb:14:in
from_block_ast'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:199:in
block in
each_context_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:183:in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
block in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
each'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
block in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
each'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:194:in
each_context_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:100:in
walk!'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/convention.rb:132:in
local'\n/Users/lekemula/Projects/solargraph/lib/solargraph/convention.rb:36:in
block in
for_local'\n/Users/lekemula/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/set.rb:501:in
each_key'\n/Users/lekemula/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/set.rb:501:in
each'\n/Users/lekemula/Projects/solargraph/lib/solargraph/convention.rb:35:in
for_local'\n/Users/lekemula/Projects/solargraph/lib/solargraph/source_map.rb:33:in
initialize'\n/Users/lekemula/Projects/solargraph/lib/solargraph/source_map.rb:157:in
new'\n/Users/lekemula/Projects/solargraph/lib/solargraph/source_map.rb:157:in
map'\n/Users/lekemula/Projects/solargraph/lib/solargraph/library.rb:475:in
next_map'\n/Users/lekemula/Projects/solargraph/lib/solargraph/language_server/host.rb:862:in
sync_library_map'\n/Users/lekemula/Projects/solargraph/lib/solargraph/language_server/host.rb:851:in
`block in library_map'\n"

```
[ERROR][2025-09-05 14:24:44] ...p/_transport.lua:36 "rpc" "solargraph"
"stderr" "[WARN] [RSpec] Error processing
/Users/lekemula/Projects/solargraph/spec/diagnostics/rubocop_helpers_spec.rb:
undefined method type' for
nil\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker/rspec_context_namespace.rb:14:in
from_block_ast'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:199:in
block in
each_context_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:183:in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
block in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
each'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
block in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
each'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:187:in
each_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:194:in
each_context_block'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/spec_walker.rb:100:in
walk!'\n/Users/lekemula/.rvm/gems/ruby-3.3.1/gems/solargraph-rspec-0.5.3/lib/solargraph/rspec/convention.rb:132:in
local'\n/Users/lekemula/Projects/solargraph/lib/solargraph/convention.rb:36:in
block in
for_local'\n/Users/lekemula/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/set.rb:501:in
each_key'\n/Users/lekemula/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/set.rb:501:in
each'\n/Users/lekemula/Projects/solargraph/lib/solargraph/convention.rb:35:in
for_local'\n/Users/lekemula/Projects/solargraph/lib/solargraph/source_map.rb:33:in
initialize'\n/Users/lekemula/Projects/solargraph/lib/solargraph/source_map.rb:157:in
new'\n/Users/lekemula/Projects/solargraph/lib/solargraph/source_map.rb:157:in
map'\n/Users/lekemula/Projects/solargraph/lib/solargraph/library.rb:475:in
next_map'\n/Users/lekemula/Projects/solargraph/lib/solargraph/language_server/host.rb:862:in
sync_library_map'\n/Users/lekemula/Projects/solargraph/lib/solargraph/language_server/host.rb:851:in
`block in library_map'\n"
```
Copilot AI review requested due to automatic review settings September 6, 2025 18:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a nil reference error in the Solargraph RSpec diagnostics by adding a null check before accessing the type method on the ast variable.

  • Adds a guard clause to prevent nil dereference when processing RSpec context blocks
  • Prevents the error "undefined method `type' for nil" that was breaking Solargraph diagnostics

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.60%. Comparing base (0e793bd) to head (5468044).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   86.59%   86.60%   +0.01%     
==========================================
  Files          23       23              
  Lines        1104     1105       +1     
  Branches       76       77       +1     
==========================================
+ Hits          956      957       +1     
  Misses        148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lekemula lekemula merged commit ae2c4b8 into main Sep 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants