refactor(master): Modernize master-metalogger comm

[rolysr]

Previous version of the master to metalogger service communication was using an old C-styled code, which made this implementation hard to maintain and understand. Also, previous manual memory assigment and free was performed manually, which is an error-prone approach. This commit modernizes the master to metaloggers service by moving to a C++-style based code.

[Copilot]

Pull Request Overview

This PR modernizes the matomlserv.cc file by refactoring it from C-style code to modern C++. The changes replace manual memory management with RAII patterns, use STL containers instead of raw pointers and manual linked lists, and adopt modern C++ conventions throughout.

Key changes include:

• Replaced manual memory management and linked lists with std::deque, std::queue, and std::vector
• Introduced InputPacket and OutputPacket wrapper classes for safer packet handling
• Converted C-style strings to std::string and enums to enum class
• Modernized logging from safs_pretty_syslog to safs::log_* functions
• Replaced macros with constexpr constants

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[rolysr]

@gemini-code-assist review

[gemini-code-assist]

Code Review

This pull request is an excellent step towards modernizing the master-metalogger communication service. The transition from C-style manual memory management to C++ containers like std::deque, std::vector, and std::string greatly improves code readability, maintainability, and safety by leveraging RAII. The use of enum class and constexpr is also a welcome improvement.

While the refactoring is very well done, I've identified a critical issue where a cleanup function is not called, leading to resource leaks and potential dangling pointers. I've also found a few minor issues related to incorrect logging format strings and a degradation in error reporting. My detailed comments are below.

[lgsilva3087]

It is looking great. Please see my comments.

[lgsilva3087]

LGTM. Great job.