Skip to content

perf: Change HDD read params default values #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

perf: Change HDD read params default values #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/sfschunkserver.cfg.5.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ in a single write job. If possible, will try to make a single pwrite call

*MAX_BLOCKS_PER_HDD_READ_JOB*:: maximum number of blocks read from the device
in a single read job. If possible, will try to make a single pread call
(default is 8, minimum is 1)
(default is 16, minimum is 1)

*MAX_PARALLEL_HDD_READ_JOBS_PER_CS_ENTRY*:: maximum number of read jobs processed
in parallel per client connection (default is 16)
in parallel per client connection (default is 1)

*READ_AHEAD_KB*:: additional number of kilobytes which should be passed to
posix_fadvise(POSIX_FADV_WILLNEED) before reading data from a chunk (default is
Expand Down
4 changes: 2 additions & 2 deletions src/admin/dump_config_command.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,8 @@ const static std::unordered_map<std::string, std::string> defaultOptionsCS = {
{"NR_OF_HDD_WORKERS_PER_NETWORK_WORKER", "16"},
{"BGJOBSCNT_PER_NETWORK_WORKER", "4000"},
{"MAX_BLOCKS_PER_HDD_WRITE_JOB", "16"},
{"MAX_BLOCKS_PER_HDD_READ_JOB", "8"},
{"MAX_PARALLEL_HDD_READ_JOBS_PER_CS_ENTRY", "16"},
{"MAX_BLOCKS_PER_HDD_READ_JOB", "16"},
{"MAX_PARALLEL_HDD_READ_JOBS_PER_CS_ENTRY", "1"},
{"MAX_READ_BEHIND_KB", "0"},
{"PERFORM_FSYNC", "1"},
{"STAT_CHUNKS_AT_DISK_SCAN", "1"},
Expand Down
4 changes: 2 additions & 2 deletions src/chunkserver/network_worker_thread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ class NetworkWorkerThread {
static constexpr uint32_t kDefaultNumberOfHddWorkersPerNetworkWorker = 16;
static constexpr uint32_t kDefaultMaxBackgroundJobsPerNetworkWorker = 4000;

static constexpr uint16_t kDefaultMaxParallelHddReadJobsPerCsEntry = 16;
static constexpr uint16_t kDefaultMaxBlocksPerHddReadJob = 8;
static constexpr uint16_t kDefaultMaxParallelHddReadJobsPerCsEntry = 1;
static constexpr uint16_t kDefaultMaxBlocksPerHddReadJob = 16;

static constexpr uint16_t kDefaultMaxBlocksPerHddWriteJob = 16;
static constexpr uint16_t kMinBlocksPerHddWriteJob = 1;
Expand Down
8 changes: 4 additions & 4 deletions src/data/sfschunkserver.cfg.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,12 @@
# MAX_BLOCKS_PER_HDD_WRITE_JOB = 16

## Maximum number of blocks read from the device in a single read job. If possible,
## will try to make a single pread call. (Default: 8, Minimum: 1)
# MAX_BLOCKS_PER_HDD_READ_JOB = 8
## will try to make a single pread call. (Default: 16, Minimum: 1)
# MAX_BLOCKS_PER_HDD_READ_JOB = 16

## Maximum number of read jobs processed in parallel per client connection.
## (Default: 16)
# MAX_PARALLEL_HDD_READ_JOBS_PER_CS_ENTRY = 16
## (Default: 1)
# MAX_PARALLEL_HDD_READ_JOBS_PER_CS_ENTRY = 1

## additional number of kilobytes which should be passed to
## posix_fadvise(POSIX_FADV_WILLNEED) before reading data from a chunk
Expand Down