Skip to content

Rebrand config files, paths, users and bins to Leilfs#873

Draft
rolysr wants to merge 6 commits into
devfrom
rebrand-tests-users-paths-to-leilfs
Draft

Rebrand config files, paths, users and bins to Leilfs#873
rolysr wants to merge 6 commits into
devfrom
rebrand-tests-users-paths-to-leilfs

Conversation

@rolysr
Copy link
Copy Markdown
Collaborator

@rolysr rolysr commented May 28, 2026

This pull request completes the rebranding of the project to "LeilFS" across documentation, configuration, install paths, user defaults, and test scripts. The main changes include:

  • Documentation: Updated all manpages and related documentation to reference "LeilFS".
  • Default User: Changed default user references to "LeilFS" throughout the codebase.
  • Install Paths: Rebranded install paths and related scripts to use "LeilFS" naming.
  • Configuration Files: Updated configuration files to reflect the new "LeilFS" branding.
  • Test Scripts & Binaries: Removed legacy symlinks for old binary names (e.g., sfs*, saunafs-*) and updated all test scripts to use the new "LeilFS" binary names directly.

These changes ensure consistency in naming and paths, fully adopting the "LeilFS" identity and removing legacy references.

Related to: LS-734

@rolysr rolysr requested a review from Copilot May 28, 2026 09:49
@rolysr rolysr self-assigned this May 28, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@rolysr
Copy link
Copy Markdown
Collaborator Author

rolysr commented May 28, 2026

@gemini-code-assist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive rebranding of the codebase from "SaunaFS" (and its sfs aliases) to "LeilFS" (and leil/lfs aliases), renaming configuration files, binaries, documentation, directories, and updating test suites. The review feedback highlights several broken references and inconsistencies introduced by the rebranding process, particularly trailing hyphens in filenames (e.g., metadata.leil-, changelog.*.leil-) and manual page references (e.g., leil-(7)). Additionally, some configuration descriptions and scripts still refer to the old "SaunaFS" or sfsmount names instead of the rebranded equivalents.

Comment thread doc/leil-master.8.adoc Outdated
Comment thread doc/leil-master.8.adoc Outdated
Comment thread doc/leil-metarestore.8.adoc Outdated
Comment thread doc/leil-metarestore.8.adoc Outdated
Comment thread doc/leil.1.adoc Outdated
Comment thread doc/leil-metalogger.8.adoc Outdated
Comment thread doc/leil-metalogger.8.adoc Outdated
Comment thread src/uraft/leil-uraft-helper.in Outdated
Comment thread CMakeLists.txt Outdated
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Hello! I see you've completed the rebranding of the project to "LeilFS". This is a massive undertaking, and it looks like you've been very thorough in updating documentation, configuration files, install paths, and test scripts.

Since this is a large-scale rename, I recommend double-checking a few areas that might have been missed:

  1. Build Artifacts/Packages: Ensure that any CI/CD pipelines or packaging scripts (like RPM/DEB specs) are updated to reflect the new binary names and package naming conventions.
  2. Systemd Service Files: Check if any systemd service files (if present in the repository or generated) need their ExecStart paths or service names updated to match the new leil-* binary names.
  3. Test Infrastructure: You've updated the test scripts, which is great. Please ensure that the CI environment variables (like SAUNAFS_ROOT which I see you've updated to LEILFS_ROOT in some places) are consistently updated across all CI configurations to avoid runtime failures.

This looks like a solid set of changes to complete the transition. Let me know if you'd like me to perform a more targeted review on any specific module!

@rolysr rolysr force-pushed the rebrand-tests-users-paths-to-leilfs branch 2 times, most recently from b75c828 to 11cef3d Compare May 28, 2026 12:02
@rolysr
Copy link
Copy Markdown
Collaborator Author

rolysr commented May 28, 2026

@gemini-code-assist review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive rebranding of the project from SaunaFS to LeilFS, renaming binaries, configuration files, documentation, and test scripts. The code review feedback highlights several instances of incomplete rebranding, particularly in the test suite configurations where legacy mount options (such as sfsdirentrycacheto, sfscachemode, and sfsmeta) need to be updated to their new leil- prefixed equivalents. Additionally, the reviewer identified several leftover textual references to 'Sauna File System' and 'SaunaFS' in the documentation, CGI scripts, configuration templates, and helper scripts that should be updated to complete the rebranding.

Comment thread tests/test_suites/ShortSystemTests/test_direntrycache_checks.sh Outdated
Comment thread tests/test_suites/ShortSystemTests/test_chunkserver_force_timeout_reads.sh Outdated
Comment thread tests/test_suites/LongSystemTests/test_trash_long_readdir.sh Outdated
Comment thread tests/test_suites/ShortSystemTests/test_create_empty_reserved_files.sh Outdated
Comment thread tests/test_suites/ShortSystemTests/test_acl_cache.sh Outdated
Comment thread CMakeLists.txt Outdated
Comment thread doc/leil-master.8.adoc Outdated
Comment thread doc/leil-chunkserver.8.adoc Outdated
Comment thread doc/leil-metarestore.8.adoc Outdated
Comment thread tests/test_suites/SanityChecks/test_petabyte_file.sh
@rolysr rolysr force-pushed the rebrand-tests-users-paths-to-leilfs branch 2 times, most recently from 54b58f9 to 0496069 Compare May 28, 2026 12:44
@rolysr rolysr changed the title Rebrand tests users paths to leilfs Rebrand config files, paths, users and bins to Leilfs May 28, 2026
@rolysr
Copy link
Copy Markdown
Collaborator Author

rolysr commented May 28, 2026

@gemini-code-assist review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive rebranding of the codebase from SaunaFS (sfs) to LeilFS (leil/lfs), updating configuration paths, documentation, build scripts, and test suites. The review feedback highlights that removing legacy symlinks and aliases (such as saunafs-cgiserver and saunafs) breaks backward compatibility for existing users and automated scripts, and recommends preserving these aliases to maintain compatibility.

I am having trouble creating individual review comments. Click here to see my feedback.

src/cgi/CMakeLists.txt (5-8)

medium

Removing the legacy symlink/alias saunafs-cgiserver breaks backward compatibility for existing users or automated scripts that rely on the legacy naming. Per our guidelines, when rebranding or renaming scripts, we should maintain backward compatibility by preserving redirects or aliases to legacy names. If restoring the symlink using platform-specific commands like ln -sf, please ensure it is explicitly guarded by platform checks (e.g., if(NOT MINGW)) to ensure compatibility across systems.

References
  1. When rebranding or renaming scripts, maintain backward compatibility by preserving redirects or aliases to legacy names (e.g., 'sfs.cgi') to avoid breaking existing user links or bookmarks.
  2. In CMake, platform-specific commands like 'ln -sf' for symlink creation are acceptable if they are explicitly guarded by platform checks (e.g., 'if(NOT MINGW)') to ensure they only execute on compatible systems.

src/tools/CMakeLists.txt (34-38)

medium

Removing the legacy saunafs symlink/alias breaks backward compatibility for existing users and automated scripts. Per our guidelines, when rebranding or renaming scripts, we should maintain backward compatibility by preserving redirects or aliases to legacy names. If restoring the symlink using platform-specific commands like ln -sf, please ensure it is explicitly guarded by platform checks (e.g., if(NOT MINGW)) to ensure compatibility across systems.

References
  1. When rebranding or renaming scripts, maintain backward compatibility by preserving redirects or aliases to legacy names (e.g., 'sfs.cgi') to avoid breaking existing user links or bookmarks.
  2. In CMake, platform-specific commands like 'ln -sf' for symlink creation are acceptable if they are explicitly guarded by platform checks (e.g., 'if(NOT MINGW)') to ensure they only execute on compatible systems.

@rolysr rolysr force-pushed the rebrand-tests-users-paths-to-leilfs branch 2 times, most recently from ee423f1 to 18f73f2 Compare May 29, 2026 11:47
@rolysr
Copy link
Copy Markdown
Collaborator Author

rolysr commented May 29, 2026

@gemini-code-assist review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive rebranding of the codebase, transitioning from the legacy 'SaunaFS' (and 'sfs') branding to 'LeilFS' (and 'leil') across build configurations, documentation, source files, and test suites. The review feedback correctly identifies several instances in the test suites where the legacy 'saunafs' name was accidentally introduced or retained during renaming (such as in helper functions, variables, and utility names) and suggests replacing them with the new 'leil' or 'leilfs' brand names to ensure a complete and consistent rebranding.

Comment thread tests/test_suites/GaneshaTests/test_nfs_ganesha_file_locks_ping_pong.sh Outdated
Comment thread tests/test_suites/ShortSystemTests/test_file_locks_ping_pong.sh Outdated
Comment thread tests/test_suites/ShortSystemTests/test_chunkserver_force_timeout_reads.sh Outdated
Comment thread tests/test_suites/ShortSystemTests/test_case_insensitive_filesystem.sh Outdated
Comment thread tests/test_suites/ShortSystemTests/test_saunafs_mount_info.sh Outdated
Comment thread tests/test_suites/ShortSystemTests/test_slow_rereads.sh Outdated
Comment thread tests/test_suites/ShortSystemTests/test_quota_dir_size.sh
@rolysr rolysr force-pushed the rebrand-tests-users-paths-to-leilfs branch 2 times, most recently from 2797ade to 0aaf7aa Compare May 29, 2026 12:40
rolysr added 6 commits May 29, 2026 15:09
Previously, it was used symlinks with older sfs* and saunafs-* prefixes
to keep compatibility with testing framework execution while introducing
the new binaries. This commit gets rid of those symlinks while updating
main testing scripts to refer to new binary names only.

Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants