Rebrand config files, paths, users and bins to Leilfs#873
Conversation
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive rebranding of the codebase from "SaunaFS" (and its sfs aliases) to "LeilFS" (and leil/lfs aliases), renaming configuration files, binaries, documentation, directories, and updating test suites. The review feedback highlights several broken references and inconsistencies introduced by the rebranding process, particularly trailing hyphens in filenames (e.g., metadata.leil-, changelog.*.leil-) and manual page references (e.g., leil-(7)). Additionally, some configuration descriptions and scripts still refer to the old "SaunaFS" or sfsmount names instead of the rebranded equivalents.
|
Hello! I see you've completed the rebranding of the project to "LeilFS". This is a massive undertaking, and it looks like you've been very thorough in updating documentation, configuration files, install paths, and test scripts. Since this is a large-scale rename, I recommend double-checking a few areas that might have been missed:
This looks like a solid set of changes to complete the transition. Let me know if you'd like me to perform a more targeted review on any specific module! |
b75c828 to
11cef3d
Compare
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive rebranding of the project from SaunaFS to LeilFS, renaming binaries, configuration files, documentation, and test scripts. The code review feedback highlights several instances of incomplete rebranding, particularly in the test suite configurations where legacy mount options (such as sfsdirentrycacheto, sfscachemode, and sfsmeta) need to be updated to their new leil- prefixed equivalents. Additionally, the reviewer identified several leftover textual references to 'Sauna File System' and 'SaunaFS' in the documentation, CGI scripts, configuration templates, and helper scripts that should be updated to complete the rebranding.
54b58f9 to
0496069
Compare
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive rebranding of the codebase from SaunaFS (sfs) to LeilFS (leil/lfs), updating configuration paths, documentation, build scripts, and test suites. The review feedback highlights that removing legacy symlinks and aliases (such as saunafs-cgiserver and saunafs) breaks backward compatibility for existing users and automated scripts, and recommends preserving these aliases to maintain compatibility.
I am having trouble creating individual review comments. Click here to see my feedback.
src/cgi/CMakeLists.txt (5-8)
Removing the legacy symlink/alias saunafs-cgiserver breaks backward compatibility for existing users or automated scripts that rely on the legacy naming. Per our guidelines, when rebranding or renaming scripts, we should maintain backward compatibility by preserving redirects or aliases to legacy names. If restoring the symlink using platform-specific commands like ln -sf, please ensure it is explicitly guarded by platform checks (e.g., if(NOT MINGW)) to ensure compatibility across systems.
References
- When rebranding or renaming scripts, maintain backward compatibility by preserving redirects or aliases to legacy names (e.g., 'sfs.cgi') to avoid breaking existing user links or bookmarks.
- In CMake, platform-specific commands like 'ln -sf' for symlink creation are acceptable if they are explicitly guarded by platform checks (e.g., 'if(NOT MINGW)') to ensure they only execute on compatible systems.
src/tools/CMakeLists.txt (34-38)
Removing the legacy saunafs symlink/alias breaks backward compatibility for existing users and automated scripts. Per our guidelines, when rebranding or renaming scripts, we should maintain backward compatibility by preserving redirects or aliases to legacy names. If restoring the symlink using platform-specific commands like ln -sf, please ensure it is explicitly guarded by platform checks (e.g., if(NOT MINGW)) to ensure compatibility across systems.
References
- When rebranding or renaming scripts, maintain backward compatibility by preserving redirects or aliases to legacy names (e.g., 'sfs.cgi') to avoid breaking existing user links or bookmarks.
- In CMake, platform-specific commands like 'ln -sf' for symlink creation are acceptable if they are explicitly guarded by platform checks (e.g., 'if(NOT MINGW)') to ensure they only execute on compatible systems.
ee423f1 to
18f73f2
Compare
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive rebranding of the codebase, transitioning from the legacy 'SaunaFS' (and 'sfs') branding to 'LeilFS' (and 'leil') across build configurations, documentation, source files, and test suites. The review feedback correctly identifies several instances in the test suites where the legacy 'saunafs' name was accidentally introduced or retained during renaming (such as in helper functions, variables, and utility names) and suggests replacing them with the new 'leil' or 'leilfs' brand names to ensure a complete and consistent rebranding.
2797ade to
0aaf7aa
Compare
Previously, it was used symlinks with older sfs* and saunafs-* prefixes to keep compatibility with testing framework execution while introducing the new binaries. This commit gets rid of those symlinks while updating main testing scripts to refer to new binary names only. Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
Signed-off-by: Rolando Sánchez Ramos <rolysr@leil.io>
0aaf7aa to
a7b0577
Compare
This pull request completes the rebranding of the project to "LeilFS" across documentation, configuration, install paths, user defaults, and test scripts. The main changes include:
These changes ensure consistency in naming and paths, fully adopting the "LeilFS" identity and removing legacy references.
Related to: LS-734