Add optional mod to terminals #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
force-pushed
the
add-optional-mods-terminal
branch
from
d8d2db8 to
7b1a3d9
Compare
leebyron
reviewed
Jun 15, 2017
src/grammar.pegjs
Outdated
| } | ||
|
|
||
| terminal = value:$(([^ \n"/`] [^ \n"\`,\]\}]*)) { | ||
| terminal = value:$(([^ ?\n"/`] [^ ?\n"\`,\]\}]*)) quantifier:('?')? { |
Owner
There was a problem hiding this comment.
I don't think it's necessary to change here as well. ? as part of a terminal should be allowed. I think it is okay to require quoting the terminal to apply a ? to remove ambiguity.
leebyron
reviewed
Jun 15, 2017
src/grammar.pegjs
Outdated
| } | ||
|
|
||
| quotedTerminal = '`' value:$(([^`\n] / ('\\`'))+)? closer:'`' { | ||
| quotedTerminal = '`' value:$(([^`\n] / ('\\`'))+)? closer:'`' quantifier:('?')? { |
Owner
There was a problem hiding this comment.
For completeness, this should include all of the possible quantifiers. See nonTerminal for an example of that
Owner
|
Could you include a reference to this in the specmd documentation? That sort of serves as its own test. |
leebyron
requested changes
Jun 16, 2017
Owner
leebyron
left a comment
leebyron
left a comment
There was a problem hiding this comment.
Tossing this back into your review queue for the addition of docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed on this PR graphql/graphql-spec#323 (comment)
This looks like this now