Skip to content

Conversation

@astrainfinita
Copy link
Collaborator

@astrainfinita astrainfinita commented Oct 20, 2025

This PR builds upon #8370 and avoids Algebra β„š typeclass assumptions wherever possible.

Many [NormedAlgebra β„š 𝔸] can be generalized to [NontriviallyNormedField 𝕂] [CharZero 𝕂] [ContinuousSMul β„š 𝕂] [NormedAlgebra 𝕂 𝔸], which basically means allowing β„š to use other equivalent norms, and may not be the case of concern.

It might be possible to use some Prop-valued typeclasses to avoid the diamond problem potentially caused by [NormedAlgebra β„š 𝔸]. This makes it unnecessary to manually obtain [NormedAlgebra β„š 𝔸] when we have [NormedAlgebra ℝ 𝔸] or [NormedAlgebra β„‚ 𝔸].

Co-authored-by: Eric Wieser [email protected]


There are still some documentation comments that need to be updated.

Zulip: #mathlib4 > Real.exp @ πŸ’¬

Open in Gitpod

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 11, 2025
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 11, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 12, 2025
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this approach, thanks!

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 12, 2025
@astrainfinita astrainfinita removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 12, 2025
Comment on lines +107 to 109
/-- `NormedSpace.exp : 𝔸 β†’ 𝔸` is the exponential map. It is defined as the sum of the
`FormalMultilinearSeries` `expSeries β„š 𝔸`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we should say more now, because we're giving a (perfectly reasonable) junk value if 𝔸 can't be equipped with a β„š-algebra structure.

Some detailed comments about the reason it's being done this way, what problems it solves and how it avoids downsides should be given in the module documentation. Then this docstring should reference the module documentation saying something like: "for details on why this approach is taken, see the module documentation for Mathlib/Analysis/Normed/Algebra/Exponential.lean"

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 14, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 15, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 31, 2025
@astrainfinita astrainfinita removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants