-
Notifications
You must be signed in to change notification settings - Fork 976
refactor(Analysis/NormedSpace/Exponential): remove the π argument from exp
#30706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor(Analysis/NormedSpace/Exponential): remove the π argument from exp
#30706
Conversation
|
This PR/issue depends on:
|
|
This pull request has conflicts, please merge |
j-loreaux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this approach, thanks!
| /-- `NormedSpace.exp : πΈ β πΈ` is the exponential map. It is defined as the sum of the | ||
| `FormalMultilinearSeries` `expSeries β πΈ`. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we should say more now, because we're giving a (perfectly reasonable) junk value if πΈ can't be equipped with a β-algebra structure.
Some detailed comments about the reason it's being done this way, what problems it solves and how it avoids downsides should be given in the module documentation. Then this docstring should reference the module documentation saying something like: "for details on why this approach is taken, see the module documentation for Mathlib/Analysis/Normed/Algebra/Exponential.lean"
|
This pull request has conflicts, please merge |
This PR builds upon #8370 and avoids
Algebra βtypeclass assumptions wherever possible.Many
[NormedAlgebra β πΈ]can be generalized to[NontriviallyNormedField π] [CharZero π] [ContinuousSMul β π] [NormedAlgebra π πΈ], which basically means allowingβto use other equivalent norms, and may not be the case of concern.It might be possible to use some Prop-valued typeclasses to avoid the diamond problem potentially caused by
[NormedAlgebra β πΈ]. This makes it unnecessary to manually obtain[NormedAlgebra β πΈ]when we have[NormedAlgebra β πΈ]or[NormedAlgebra β πΈ].Co-authored-by: Eric Wieser [email protected]
There are still some documentation comments that need to be updated.
Zulip: #mathlib4 > Real.exp @ π¬