Skip to content

Conversation

@someaddons
Copy link
Contributor

Closes #
Closes #

Changes proposed in this pull request

  • Change rendering nice check to be context insensitive similar to the placeholder override

Testing

  • [ x] Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

}

blockAccess.setSolidSubstitutionOverride(null);
blockAccess.setRenderBlocksNiceOverride(Structurize.getConfig().getClient() != null && Structurize.getConfig().getClient().renderPlaceholdersNice.get());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is client only code, same below

Suggested change
blockAccess.setRenderBlocksNiceOverride(Structurize.getConfig().getClient() != null && Structurize.getConfig().getClient().renderPlaceholdersNice.get());
blockAccess.setRenderBlocksNiceOverride(Structurize.getConfig().getClient().renderPlaceholdersNice.get());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still in the other file, mergeable

@someaddons someaddons merged commit 44face5 into version/1.21 Jun 2, 2025
4 checks passed
@someaddons someaddons deleted the rendernice branch June 2, 2025 12:04
someaddons added a commit that referenced this pull request Jun 2, 2025
someaddons added a commit that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants