Avoid infinite loops in falling block placement handler #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightenom
reviewed
Apr 30, 2025
src/main/java/com/ldtteam/structurize/placement/handlers/placement/PlacementHandlers.java
Show resolved
Hide resolved
Contributor
|
Shouldn't this be fixed if we align the checks? Doesn't our solid check also look for falling block?
…-------- Original Message --------
On 5/2/25 02:51, TommyC81 wrote:
@TommyC81 commented on this pull request.
---------------------------------------------------------------
In [src/main/java/com/ldtteam/structurize/placement/handlers/placement/PlacementHandlers.java](#741 (comment)):
> @@ -249,13 +252,23 @@ public List<ItemStack> getRequiredItems(
posBelow = posBelow.below();
final boolean isFirstTest = i == 0;
final BlockState possibleSupport = BlockUtils.getWorldgenBlock(world, posBelow, bp -> isFirstTest ? blockState : null);
- if (possibleSupport != null && BlockUtils.canBlockFloatInAir(possibleSupport) && !canHandle(world, posBelow, possibleSupport))
+ if (possibleSupport != null && BlockUtils.isAnySolid(possibleSupport) && BlockUtils.canBlockFloatInAir(possibleSupport) && !canHandle(world,
+ posBelow,
+ possibleSupport))
{
supportBlockState = possibleSupport;
I posted the original bug report, is there anything I can test or do to assist with finding a possible cause or contributing mod? I'm using a quite extensive modpack and so far all works well apart from this item. If it is useful or make any difference; the error occurs when opening the 'Build Options' menu, sometimes the menu opens but freezes shortly after, sometimes it doesn't open at all - maybe coincidental?
—
Reply to this email directly, [view it on GitHub](#741 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ABRD3S3BGTWT2HJCFMKU5TT24JNKRAVCNFSM6AAAAAB4GBOUASVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMJQGMZTMNZQGQ).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Contributor
Author
|
Align which checks? I added the solid check as requirement for the supporting block |
Add fallback to cobble
Nightenom
previously approved these changes
May 2, 2025
Raycoms
previously approved these changes
May 2, 2025
Contributor
|
Note that in case of terrafirmacraft, cobblestone is also a falling block. So that might not work as fallback |
Contributor
Maybe we go with classic stone then ? |
Contributor
|
That should work better |
|
Has this been implemented in the 1. 21.1 version? |
|
Thank you all, can confirm that I no longer get error, and things appear to work correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #740
Changes proposed in this pull request
Testing
Review please