feat: flexible LLM configuration with optional API keys #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements comprehensive support for custom VLM and Embedding model configurations, including local providers that don't require API keys. Key Changes: - Enhanced LLMProvider enum with Ollama, LocalAI, LlamaCPP, and Custom providers - Added is_api_key_optional() method for provider-aware API key validation - Unified validation and rollback mechanism for both VLM and Embedding clients - Improved settings.py to delegate API key validation to LLMClient - Added comprehensive LLM Configuration Guide with examples - Provided Ollama example configuration file Benefits: - Support for local LLM providers without API keys (Ollama, LocalAI, etc.) - Graceful rollback on reinitialization failures - More flexible and extensible provider support - Better error messages and validation Fixes: API key validation preventing use of local models Addresses: User request for custom VLM and embedding model configuration Co-authored-by: Droid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements comprehensive support for custom VLM and Embedding model configurations, including local providers that don't require API keys.
Key Changes:
Benefits:
Fixes: API key validation preventing use of local models
Addresses: User request for custom VLM and embedding model configuration
Description
Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please
mention it here.
Closes: #(issue)
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue
for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.