Fixes #3589: ELF COMDAT needed on templates to enable linker data culling #4747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inker data culling
the-horo
reviewed
Sep 7, 2024
Comment on lines
+287
to
+294
| return !(triple.isOSBinFormatMachO() || | ||
| #if LDC_LLVM_VER >= 500 | ||
| triple.isOSBinFormatWasm() | ||
| #else | ||
| triple.getArch() == llvm::Triple::wasm32 || | ||
| triple.getArch() == llvm::Triple::wasm64 | ||
| #endif | ||
| ); |
Contributor
There was a problem hiding this comment.
Suggested change
| return !(triple.isOSBinFormatMachO() || | |
| #if LDC_LLVM_VER >= 500 | |
| triple.isOSBinFormatWasm() | |
| #else | |
| triple.getArch() == llvm::Triple::wasm32 || | |
| triple.getArch() == llvm::Triple::wasm64 | |
| #endif | |
| ); | |
| return !(triple.isOSBinFormatMachO() || triple.isOSBinFormatWasm()); |
Even if isOSBinFormatWasm was added in llvm 5, ldc only supports >=llvm-15 so LDC_LLVM_VER will always be >= 1500
Author
There was a problem hiding this comment.
This was picked from older code, before it got removed. I'll remove this, since llvm-5 is no longer supported by LDC.
Member
|
Alternative in #4748, with a proper test case and leaving |
Author
|
Superseded by #4748 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.