Skip to content

Lazily IR-declare all function fwd declarations #4420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinke merged 1 commit into from
Jun 10, 2023
Merged

Lazily IR-declare all function fwd declarations #4420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gen/declarations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,9 @@ class CodegenVisitor : public Visitor {

void visit(FuncDeclaration *decl) override {
// don't touch function aliases, they don't contribute any new symbols
if (!decl->skipCodegen() && !decl->isFuncAliasDeclaration()) {
if (!decl->skipCodegen() && !decl->isFuncAliasDeclaration() &&
// skip fwd declarations (IR-declared lazily)
decl->fbody) {
DtoDefineFunction(decl);
}
}
Expand Down
6 changes: 3 additions & 3 deletions tests/codegen/attr_callingconvention.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,16 @@ void fooinvokesexternCfoofoofoo()
//////////////////////////////////////////////////////////
/// Forward-declared function calls and invokes:

// CHECK-LABEL: declare x86_vectorcallcc void @{{.*}}forward_declared_function
@callingConvention("vectorcall") void forward_declared_function();

// CHECK-LABEL: define{{.*}} @{{.*}}attr_callingconvention34foocalls_forward_declared_function
void foocalls_forward_declared_function()
{
// CHECK: call x86_vectorcallcc void @{{.*}}attr_callingconvention25forward_declared_function
forward_declared_function();
}

// CHECK-LABEL: declare x86_vectorcallcc void @{{.*}}forward_declared_function
@callingConvention("vectorcall") void forward_declared_function();

// CHECK-LABEL: define{{.*}} @{{.*}}attr_callingconvention36fooinvokes_forward_declared_function
void fooinvokes_forward_declared_function()
{
Expand Down
4 changes: 4 additions & 0 deletions tests/compilable/gh2782.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// RUN: %ldc -c -singleobj %s %S/inputs/gh2782b.d

struct S {}
extern(C) void foo(S);
2 changes: 2 additions & 0 deletions tests/compilable/inputs/gh2782b.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
struct S {}
extern(C) void foo(S);