fix: security hardening — credential masking, file permissions, config wiring#2
Merged
lazy-dinosaur merged 1 commit intolazy-dinosaur:masterfrom Mar 19, 2026
Merged
Conversation
…ons, config wiring - Add maskCredentials() utility to redact API keys/secrets from log output - Replace JSON.stringify(account) with maskCredentials(account) in validation warnings - Restore error logging on CCXT init failure with safe error.message extraction - Add config file permission check — warns if world-readable (recommends chmod 600) - Wire through all AccountConfig options (password, uid, privateKey, walletAddress, enableRateLimit, timeout, proxy, exchange-specific options) to CCXT instances Co-Authored-By: Claude Opus 4.6 <[email protected]>
Owner
|
Thank you for PR!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSON.stringify(account)was leakingapiKey,secret,password, andprivateKeyto stderr. AddedmaskCredentials()helper that redacts sensitive fields before logging.chmod 600).password,uid,privateKey,walletAddress,enableRateLimit,timeout,proxy, andaccount.optionsare now passed to the CCXT constructor. Previously onlyapiKey,secret, anddefaultTypewere used.error.message, not the raw error object.Test plan
npx tsc --noEmitpassespassword/uidfields now connect correctly[XaX] https://XautomateX.com