Desktop: OneNote import: Fix all imported notes have the language marked as "English" #14054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
changed the title
Owner
Thanks for looking into this but I don't feel that will be needed, especially if we don't currently use this information in Joplin. Should it ever become needed, I'm guessing that it will be possible to reliably detect the language using AI for these notes and others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, HTML imported from OneNote always had
lang="en"set on the<html>element, even if the imported content was not English. With this change, the<html>element lacks alangattribute.Note
The
langattribute on<html>seems to be ignored by Joplin when rendering HTML notes.Note
A better (but much more complicated) fix would be to set
lang="..."to the language of the document content. See https://github.com/personalizedrefrigerator/joplin/tree/pr/desktop/onenote-import/fix-language-code for a work-in-progress fix that does this.