Conversation
| document.body.appendChild(element); | ||
| const parsed = parseAbcContent(token.content); | ||
| abcjs.renderAbc(elementId, parsed.markup, { ...globalOptions, ...parsed.options }); | ||
| html = `<div class="abc-notation-block">${element.innerHTML}</div>`; |
Collaborator
There was a problem hiding this comment.
Note/non-blocking: At some point, it may make sense to update this to support the Rich Text Editor. To do this, some metadata might need to be added here.
| !f!(fgag-g2c2)| | ||
| ``` | ||
|
|
||
| `<!-- cSpell:enable --> |
Collaborator
There was a problem hiding this comment.
Suggested change
| `<!-- cSpell:enable --> | |
| <!-- cSpell:enable --> |
Collaborator
|
Thank you for implementing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow rendering sheet music in published notes. I thought it would be straightforward but I see that the plugin settings would have to be migrated to do this properly.
Todo
plugin-org.joplinapp.plugins.AbcSheetMusic.options