Desktop: Disallow unsharing a folder while sharing is in progress

[personalizedrefrigerator]

Summary

This change prevents the "Unshare" button from being clicked while a sync is in progress.

This pull request may resolve #13518, if #13518 is related to a conflict between the share and unshare actions or related to an outdated jop_share_id property on the server.

Details

When unsharing a folder, Joplin Server determines which items to mark as deleted based on the jop_share_id property:

Details

• DEL api/shares/:id calls models.share().delete:
  

  joplin/packages/server/src/routes/api/shares.ts

  Line 144 in 94725c5

  await ctx.joplin.models.share().delete(share.id);

• ...which calls userItem().deleteByShare:
  

  joplin/packages/server/src/models/ShareModel.ts

  Line 477 in 94725c5

  await this.models().userItem().deleteByShare({ id: share.id, owner_id: share.owner_id });

• ...which calls UserItemModel::deleteBy:
  

  joplin/packages/server/src/models/UserItemModel.ts

  Line 111 in 94725c5

  await this.deleteBy({ byShare: share });

• ...which gets items by the share ID:
  

  joplin/packages/server/src/models/UserItemModel.ts

  Line 200 in 94725c5

  userItems = await this.byShareId(options.byShare.id);

• ...which uses the jop_share_id property:
  

  joplin/packages/server/src/models/UserItemModel.ts

  Line 66 in 94725c5

  .where('items.jop_share_id', '=', shareId);

• ...which is synced from the Joplin clients.

Since jop_share_id comes from the Joplin clients' share_id property, the Joplin clients need to be fully synced for the results of the ... .where('items.jop_share_id', '=', shareId) query to match the data present locally.

Testing plan

1. Right-click on a notebook and click "Share notebook...".
2. Add a user by email to the share.
3. Verify that 1) the "Unshare" button isn't visible until "Synchronizing..." is and 2) "Unshare" is greyed out/disabled while "Synchronizing..." is visible.

Screen recording

Screencast.from.2025-10-27.10-19-05.webm