Desktop: Fixes #12763: skip copy event in TinyMCE if no content is selected.#13313
Merged
laurent22 merged 1 commit intolaurent22:devfrom Sep 30, 2025
Merged
Desktop: Fixes #12763: skip copy event in TinyMCE if no content is selected.#13313laurent22 merged 1 commit intolaurent22:devfrom
laurent22 merged 1 commit intolaurent22:devfrom
Conversation
…ent is selected.
Contributor
Author
|
The GIF shows TinyMCE’s default behavior: when nothing is selected, pressing Ctrl+C does nothing. Non-code editors like Word or Notepad behave the same way, so maybe that’s just the more common way WYSIWYG gets implemented?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This issue appears to occur only in the WYSIWYG (TinyMCE) editor.
In the Markdown editor, the default behavior is to copy the entire line when there is no selection, so no change is needed there.
I’ve limited the fix to TinyMCE: on copy, we first check whether there is a selection; if not, we do nothing.
How to test
Manual testing: before the change, the issue is reproducible; after the change, the behavior matches expectations—empty (no-selection) copies have no effect.
Test gif
Before:
After:
Related issues
Fixes #12763