Mobile: Improve inline search performance in large documents#13259
Merged
laurent22 merged 2 commits intolaurent22:devfrom Sep 30, 2025
Merged
Conversation
This change improves search performance in large documents by fixing two issues: 1. Updating the search caused the initial injectedJavaScript to be recomputed. This involves serializing a JSON object that includes the initial editor text. 2. If IPC to/from the note editor was slow, the search query could reset to older values when a new search query is typed quickly.
personalizedrefrigerator
added a commit
to personalizedrefrigerator/joplin
that referenced
this pull request
Sep 22, 2025
personalizedrefrigerator
added a commit
to personalizedrefrigerator/joplin
that referenced
this pull request
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change improves search performance in large documents by fixing two issues:
injectedJavaScriptto be recomputed. This involved serializing a JSON object that includes the initial editor text. The changes to theinjectedJavaScriptobject then caused other state to update.WebView: If 1) the user was typing quickly and 2) IPC to/from the note editor was slow, the search query could reset to older values while typing.Testing plan
iOS 18.4 simulator, Web:
Web (regression testing):