Skip to content

Desktop: Resolves #12292: Add hover + expanded arrow behavior for Notebook/Tags header #13190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurent22 merged 6 commits into from
Oct 1, 2025
Merged

Desktop: Resolves #12292: Add hover + expanded arrow behavior for Notebook/Tags header #13190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aed3996
feat: Add hover + expanded arrow behavior for Notebook/Tags header
maggie897 Sep 11, 2025
f5d3cc9
Merge branch 'dev' into feat_hover_effect
laurent22 Sep 13, 2025
73302a0
Merge branch 'dev' into feat_hover_effect
laurent22 Sep 13, 2025
d40664c
Fix: useCallback for hover handlers + fix hover indent
maggie897 Sep 18, 2025
e24bdf2
Merge branch 'feat_hover_effect' of https://github.com/maggie897/jopl…
maggie897 Sep 18, 2025
29248bd
Merge branch 'dev' into feat_hover_effect
laurent22 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/app-desktop/gui/Sidebar/listItemComponents/HeaderItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { useCallback } from 'react';
import { useCallback, useState } from 'react';
import { StyledHeader, StyledHeaderIcon, StyledHeaderLabel } from '../styles';
import { HeaderId, HeaderListItem } from '../types';
import bridge from '../../../services/bridge';
Expand All @@ -25,6 +25,8 @@ const HeaderItem: React.FC<Props> = props => {
const item = props.item;
const onItemClick = item.onClick;
const itemId = item.id;
const [isHovered, setIsHovered] = useState(false);
const expanded = item.expanded;

const onClick: React.MouseEventHandler<HTMLElement> = useCallback(event => {
if (onItemClick) {
Expand All @@ -44,6 +46,14 @@ const HeaderItem: React.FC<Props> = props => {
}
}, [itemId]);

const handleMouseEnter = useCallback(() => {
setIsHovered(true);
}, []);

const handleMouseLeave = useCallback(() => {
setIsHovered(false);
}, []);

return (
<ListItemWrapper
containerRef={props.anchorRef}
Expand All @@ -58,8 +68,12 @@ const HeaderItem: React.FC<Props> = props => {
{...item.extraProps}
onDrop={props.onDrop}
>
<StyledHeader onClick={onClick}>
<StyledHeaderIcon aria-hidden='true' role='img' className={item.iconName}/>
<StyledHeader
onClick={onClick}
onMouseEnter={handleMouseEnter}
onMouseLeave={handleMouseLeave}
>
<StyledHeaderIcon aria-hidden='true' role='img' className={isHovered ? `fas ${expanded ? 'fa-caret-down' : 'fa-caret-right'}` : item.iconName}/>
<StyledHeaderLabel>{item.label}</StyledHeaderLabel>
</StyledHeader>
</ListItemWrapper>
Expand Down
5 changes: 5 additions & 0 deletions packages/app-desktop/gui/Sidebar/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ export const StyledHeader = styled.div`
user-select: none;
text-transform: uppercase;
//cursor: pointer;
cursor: default;
transition: background 0.2s;
&:hover {
background: ${(props: StyleProps) => props.theme.backgroundColorHover2};
}
`;

export const StyledHeaderIcon = styled.i`
Expand Down