Skip to content

chore: Clarify trackJudgeResult guidance in create-judge example#1381

Merged
jsonbailey merged 1 commit into
mainfrom
jb/aic-2383/improve-create-judge-comment
May 14, 2026
Merged

chore: Clarify trackJudgeResult guidance in create-judge example#1381
jsonbailey merged 1 commit into
mainfrom
jb/aic-2383/improve-create-judge-comment

Conversation

@jsonbailey
Copy link
Copy Markdown
Contributor

@jsonbailey jsonbailey commented May 14, 2026

Summary

Rewords the comment in the create-judge example that points at aiConfig.createTracker().trackJudgeResult(judgeResult) to explain why — when the output you're judging came from another AI Config, the score should be attributed to that config's tracker, not the judge's. Also drops the triple-space code-block inset to match the rest of the comment block.

No code change.


Note

Low Risk
Comment-only change in an example file; no runtime behavior or API usage is modified.

Overview
Clarifies the comment in the create-judge example to explain that trackJudgeResult should be sent to the evaluated AI Config’s tracker (when judging output from another config) so metrics are attributed correctly.

Reviewed by Cursor Bugbot for commit 11ef10a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26208 bytes
Compressed size limit: 29000
Uncompressed size: 128789 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31906 bytes
Compressed size limit: 34000
Uncompressed size: 113658 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38487 bytes
Compressed size limit: 39000
Uncompressed size: 211236 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179498 bytes
Compressed size limit: 200000
Uncompressed size: 830837 bytes

@jsonbailey jsonbailey marked this pull request as ready for review May 14, 2026 16:35
@jsonbailey jsonbailey requested a review from a team as a code owner May 14, 2026 16:35
@jsonbailey jsonbailey merged commit 68aaaf3 into main May 14, 2026
44 checks passed
@jsonbailey jsonbailey deleted the jb/aic-2383/improve-create-judge-comment branch May 14, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants