chore: Clarify trackJudgeResult guidance in create-judge example#1381
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
keelerm84
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewords the comment in the create-judge example that points at
aiConfig.createTracker().trackJudgeResult(judgeResult)to explain why — when the output you're judging came from another AI Config, the score should be attributed to that config's tracker, not the judge's. Also drops the triple-space code-block inset to match the rest of the comment block.No code change.
Note
Low Risk
Comment-only change in an example file; no runtime behavior or API usage is modified.
Overview
Clarifies the comment in the
create-judgeexample to explain thattrackJudgeResultshould be sent to the evaluated AI Config’s tracker (when judging output from another config) so metrics are attributed correctly.Reviewed by Cursor Bugbot for commit 11ef10a. Bugbot is set up for automated code reviews on this repo. Configure here.