Skip to content

refactor!: align browser v4 intialization flow to specs #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joker23 merged 10 commits into from
Dec 18, 2025
Merged

refactor!: align browser v4 intialization flow to specs #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7001f97
refactor!: update BrowserClient initialization and context handling
joker23 Dec 16, 2025
7f63565
test: add unit test for BrowserClient start method promise caching
joker23 Dec 16, 2025
5ab2362
chore: modify the wait logic to track initialization and start separa…
joker23 Dec 16, 2025
36d62de
refactor: removing `setInitialContext` from public interface
joker23 Dec 16, 2025
b0dc567
chore: addressing PR comments
joker23 Dec 17, 2025
7994552
fix: browser compat breaks due to start call being required
joker23 Dec 17, 2025
97e9856
chore: fixing issues with rebase
joker23 Dec 17, 2025
d43dae2
refactor: add optional bootstrap props to startOptions
joker23 Dec 18, 2025
2c87e55
chore: rename initialize function
joker23 Dec 18, 2025
846ae61
chore: ensure that the first identify operation is not sheddable
joker23 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/sdk/browser/__tests__/BrowserClient.plugins.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ it('registers plugins and executes hooks during initialization', async () => {

const platform = makeBasicPlatform();

const context: LDContext = { key: 'user-key', kind: 'user' };
const client = makeClient(
'client-side-id',
context,
AutoEnvAttributes.Disabled,
{
streaming: false,
Expand All @@ -55,10 +57,7 @@ it('registers plugins and executes hooks during initialization', async () => {

// Verify the plugin was registered
expect(mockPlugin.register).toHaveBeenCalled();

// Now test that hooks work by calling identify and variation
const context: LDContext = { key: 'user-key', kind: 'user' };
await client.identify(context);
await client.start();

expect(mockHook.beforeIdentify).toHaveBeenCalledWith({ context, timeout: undefined }, {});

Expand Down Expand Up @@ -134,6 +133,7 @@ it('registers multiple plugins and executes all hooks', async () => {

const client = makeClient(
'client-side-id',
{ key: 'user-key', kind: 'user' },
AutoEnvAttributes.Disabled,
{
streaming: false,
Expand All @@ -149,7 +149,7 @@ it('registers multiple plugins and executes all hooks', async () => {
expect(mockPlugin2.register).toHaveBeenCalled();

// Test that both hooks work
await client.identify({ key: 'user-key', kind: 'user' });
await client.start();
client.variation('flag-key', false);
client.track('event-key', { data: true }, 42);

Expand Down Expand Up @@ -200,6 +200,7 @@ it('passes correct environmentMetadata to plugin getHooks and register functions

makeClient(
'client-side-id',
{ kind: 'user', key: '', anonymous: true },
AutoEnvAttributes.Disabled,
{
streaming: false,
Expand Down Expand Up @@ -281,6 +282,7 @@ it('passes correct environmentMetadata without optional fields', async () => {

makeClient(
'client-side-id',
{ kind: 'user', key: '', anonymous: true },
AutoEnvAttributes.Disabled,
{
streaming: false,
Expand Down
Loading