You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We actually want to keep the __version__ in __init__.py and remove it from cli.py. Additionally, let's move the e2e changes to a separate PR.
I removed the version string and asserts from cli.py and included them in __init__.py. I need to delay the import of __version__ in cli.py to avoid a circular import dependency. An alternative solution to avoid using delay imports is to use a new version.py file to keep the version string. cc @thewhaleking
We actually want to keep the __version__ in __init__.py and remove it from cli.py. Additionally, let's move the e2e changes to a separate PR.
I removed the version string and asserts from cli.py and included them in __init__.py. I need to delay the import of __version__ in cli.py to avoid a circular import dependency. An alternative solution to avoid using delay imports is to use a new version.py file to keep the version string. cc @thewhaleking
That's a good point. Let's move this to a new version.py file. Think that's gonna be a better solution than deferred imports.
@thewhaleking it appears the run-tests job is broken due to an unrelated reason to this PR. I can look into the issues in a separate PR.
I think this is actually due to a change on testnet (which is what we use to run the e2e tests). Checking into it more in-depth now, but I believe that's the issue.
The issue is actually caused by a recent update to async-substrate-interface which slowed down things too much to work correctly. I have a fix up for it (latent-to/async-substrate-interface#56), and version 1.0.3 should be released shortly, which will allow for these to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #241