Feedback/Improvements to HTML output#21
Merged
Merged
Conversation
basfroman
approved these changes
Aug 27, 2024
Contributor
basfroman
left a comment
basfroman
left a comment
There was a problem hiding this comment.
Great job!
I would like to add that if we are concerned about user experience, we should switch to em instead of px. This will significantly affect the display of the table on different monitors. Someone is using 13 inches, and someone may have 34 inches with 5K resolution.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes an edge case where metadata K:V pairs were not updating in the DB correctly if they had the same key name but different table names.