Fix for invalid file path resolution. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced with problem that when I'm tried to measure coverage of tests ran by
mocha-puppeteerwithnyc(istanbul) it generates report where all files are placed in root. Also I was unable to open page with file coverage (it reports something likeUnable to lookup source: PlaceholderRoles.js(ENOENT: no such file or directory, open 'PlaceholderRoles.js')).I dug into this and found that problem comes from
lasso-babel-transform.path.relative(curDir, filename)will always return only name of file sincecurDiris just a folder where this file placed (see line 52).I'm not 100% sure about proposed fix, but at least it fixed my problem.