Skip to content

Conversation

@colmmurphyxyz
Copy link
Contributor

This adds support for pattern matching Tree objects in Python 3.10+ (#1487).

This is my first PR to the project. If I'm missing something, please let me know and I'll address it

@erezsh erezsh requested a review from MegaIng March 20, 2025 21:20
@MegaIng
Copy link
Member

MegaIng commented Mar 20, 2025

Version 3.9 is still supported official so we are not going to drop it. Please adjust the tests to work on those versions as well.

@colmmurphyxyz
Copy link
Contributor Author

@MegaIng I've moved the tests to tests/test_pattern_match.py, which should cause them to be skipped on python 3.8/3.9

@erezsh
Copy link
Member

erezsh commented Mar 22, 2025

Run pre-commit to fix the error

@colmmurphyxyz
Copy link
Contributor Author

Fixed. Third time's the charm 😅

@erezsh
Copy link
Member

erezsh commented Mar 22, 2025

@colmmurphyxyz Sorry to nitpick, but please revert the line change on test_trees.

@erezsh
Copy link
Member

erezsh commented Mar 22, 2025

Looks good to me.

@MegaIng Any comment?

@erezsh erezsh merged commit f68e353 into lark-parser:master Mar 22, 2025
9 checks passed
@erezsh
Copy link
Member

erezsh commented Mar 22, 2025

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants