Skip to content

Fix Symbol.__eq__ to return false when comparing with None #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erezsh merged 3 commits into from
Oct 26, 2024
+7 −3
Merged

Fix Symbol.__eq__ to return false when comparing with None #1481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da118c3
Fix Symbol.__eq__ (fixes #1476)
weaversam8 Oct 25, 2024
3ac48c1
Adjust behaviour in #1481 to raise a NotImplementedError
weaversam8 Oct 25, 2024
9d35d1b
Adjust behaviour in #1481 to return NotImplemented
weaversam8 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lark/grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ def __init__(self, name: str) -> None:
self.name = name

def __eq__(self, other):
assert isinstance(other, Symbol), other
if not isinstance(other, Symbol):
return NotImplemented
return self.is_term == other.is_term and self.name == other.name

def __ne__(self, other):
Expand Down
7 changes: 5 additions & 2 deletions tests/test_grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from lark import Lark, Token, Tree, ParseError, UnexpectedInput
from lark.load_grammar import GrammarError, GRAMMAR_ERRORS, find_grammar_errors, list_grammar_imports
from lark.load_grammar import FromPackageLoader

from lark.grammar import Symbol

class TestGrammar(TestCase):
def setUp(self):
Expand Down Expand Up @@ -296,8 +296,11 @@ def test_line_breaks(self):
p.parse('ab')


def test_symbol_eq(self):
a = None
b = Symbol("abc")


self.assertNotEqual(a, b)


if __name__ == '__main__':
Expand Down