-
Notifications
You must be signed in to change notification settings - Fork 201
Add missing translations #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jubeki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes to :href should not be included.
Co-authored-by: Julius Kiekbusch <[email protected]>
Co-authored-by: Julius Kiekbusch <[email protected]>
Co-authored-by: Julius Kiekbusch <[email protected]>
|
Thank you! |
Rattone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to fix
|
Thank you! |
Rattone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please pay close attention when making changes
|
I wonder why this linter livewire-starter-kit/.github/workflows/lint.yml Lines 36 to 37 in effc7fc
|
|
Thanks. I’m starting to hate how my VSCode is acting strangely. |
I think it doesn't work with blade/html files |
tnylea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Thanks for updating those.
As @tnylea mentioned earlier (#28 (comment)), some translations are still missing. My previous PR included all the missing translations but wasn't merged, so I recreated it to address this.