Skip to content

Conversation

@askdkc
Copy link
Contributor

@askdkc askdkc commented Feb 28, 2025

As @tnylea mentioned earlier (#28 (comment)), some translations are still missing. My previous PR included all the missing translations but wasn't merged, so I recreated it to address this.

Copy link
Contributor

@Jubeki Jubeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes to :href should not be included.

@askdkc
Copy link
Contributor Author

askdkc commented Mar 1, 2025

@Jubeki

Thank you!

Copy link
Contributor

@Rattone Rattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to fix

@askdkc
Copy link
Contributor Author

askdkc commented Mar 1, 2025

@Rattone

Thank you!

Copy link
Contributor

@Rattone Rattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pay close attention when making changes

@askdkc
Copy link
Contributor Author

askdkc commented Mar 1, 2025

@Rattone

I wonder why this linter

- name: Run Pint
run: vendor/bin/pint
doesn't catch these.

@askdkc
Copy link
Contributor Author

askdkc commented Mar 1, 2025

@Rattone

Thanks.

I’m starting to hate how my VSCode is acting strangely.

@Rattone
Copy link
Contributor

Rattone commented Mar 1, 2025

@Rattone

I wonder why this linter

- name: Run Pint
run: vendor/bin/pint

doesn't catch these.

I think it doesn't work with blade/html files

Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Thanks for updating those.

@tnylea tnylea added the Approved Approved for Merge label Mar 3, 2025
@taylorotwell taylorotwell merged commit cf109fe into laravel:main Mar 4, 2025
2 checks passed
@askdkc askdkc deleted the fix-missing-translation branch March 4, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Approved for Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants