[Proposal][5.5] intersectKeys and intersectAssoc in collections

[lk77]

Hello,

we have diffAssoc in collections now, but i think it would be meaningful to have the opposite method, intersectAssoc, to recover key / value pair of the collection that are in the given collection.

And i think we should rename intersectKey to intersectKeys to be consistent with diffKeys

what do you think ?

thanks

[lk77]

I have noticed that intersectKey method is not documented, so i've added it : laravel/docs#3461

I need this and I can't believe it's not available.

[taylorotwell]

Collection is macro-able so any functions you need that aren't there could be added that way.

[lk77]

So we need to remove diffAssoc from the framework ? i don't see the point of having one and not the other, for me they are inseparable.

Of course i can add a macro, but macro should be avoided as hell, i think it's better to stick to the framework, and not adding custom stuff that will not work in another context where the macro doesnt exist.