[12.x] try another way to activate Broadcast routes #57734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this command currently has 2 conditions it checks to try and activate the "channels" file in your `/bootstrap/app.php`. while this may cover a good chunk of users, it fails if the `commands:` named argument has been removed from the file. this change adds an additional check to look for the `->withRouting()` method call, which has a *very* high likelyhood of being in the file. placing it after the "commands" named argument is ideal because it maintains named argument order, but this is a good fallback. _if even this additional check fails_, it now returns an error message to the user telling them they need to manually activate the broadcast routes in their `/bootstrap/app.php` file. this will helpfully avoid confusion if the automatic enabling fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this command currently has 2 conditions it checks to try and activate the "channels" file in your
/bootstrap/app.php. while this may cover a good chunk of users, it fails if thecommands:named argument has been removed from the file.this change adds an additional check to look for the
->withRouting()method call, which has a very high likelyhood of being in the file. placing it after the "commands" named argument is ideal because it maintains named argument order, but this is a good fallback.if even this additional check fails, it now returns an error message to the user telling them they need to manually activate the broadcast routes in their
/bootstrap/app.phpfile. this will helpfully avoid confusion if the automatic enabling fails.