[12.x] Always cast something as fluent if column is null #56540
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address a problem when an entire column is null.
Problem
The current
AsFluentimplementation returnsnullwhen the database column is null, causing runtime errors when developers try to use Fluent methods:Rationale
By always returning a fluent, we can prevent errors when calling
->get()blindly. Since you can't set a default value forjsoncolumns in MySQL, it becomes particularly tricky to add this AsFluent cast to existing datasets.This may be a "breaking" change if anyone is dependent on checking for
nullto determine if the column was set - but realistically, most developers want to work with an empty Fluent object rather than handle null checks.