Skip to content

Conversation

@liamduckett
Copy link
Contributor

InteractsWithPivotTable::sync currently works when passing a single ID to it:

$category->food()->sync($item->id);

// works due to:
protected function parseIds($value)
{
    if ($value instanceof Model) {
        // ...
    }

    if ($value instanceof EloquentCollection) {
        // ...
    }

    if ($value instanceof BaseCollection || is_array($value)) {
        // ...
    }

    return (array) $value;
}

However, static analysis doesn't know about this, due to:

  /**
   * Sync the intermediate tables with a list of IDs or collection of models.
   *
   * @param  \Illuminate\Support\Collection|\Illuminate\Database\Eloquent\Model|array  $ids
   * @param  bool  $detaching
   * @return array{attached: array, detached: array, updated: array}
   */
  public function sync($ids, $detaching = true)

My usecase only uses int $ids but I thought it best to add string whilst I was on (for uuids).

I also applied this change to methods that call the sync method.

@taylorotwell taylorotwell merged commit 47e433b into laravel:12.x May 19, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants