[7.x] Added renameColumn() enum support#32205
Merged
taylorotwell merged 3 commits intolaravel:7.xfrom Apr 6, 2020
nuernbergerA:rename-column-support-tables-with-enum
Merged
[7.x] Added renameColumn() enum support#32205taylorotwell merged 3 commits intolaravel:7.xfrom nuernbergerA:rename-column-support-tables-with-enum
taylorotwell merged 3 commits intolaravel:7.xfrom
nuernbergerA:rename-column-support-tables-with-enum
Conversation
perifer
added a commit
to perifer/docs
that referenced
this pull request
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for tables with
enumcolumns in migration files.Current State
It's impossible to
renameColumn()orchange()column types on tables with an enum-column in your migrations.There is also a big warning in the docs.
Solution
I just add the type to doctrines internal mapping and it works.
What's still unsupported
Renaming and changing an
enumcolumn directly. I will take a look into this after this PR.Thanks to my friend @bosske1 for working with me on this.
Also thanks to @staudenmeir who was so kind as to answer my questions.