[8.x] Fixed component class view reference#32132
Merged
taylorotwell merged 2 commits intolaravel:masterfrom Mar 27, 2020
Merged
[8.x] Fixed component class view reference#32132taylorotwell merged 2 commits intolaravel:masterfrom
taylorotwell merged 2 commits intolaravel:masterfrom
Conversation
innoflash
force-pushed
the
fix-componet-class
branch
from
06571c9 to
dc38442
Compare
driesvints
approved these changes
Mar 27, 2020
GrahamCampbell
changed the title
Collaborator
|
This was merged into the wrong branch. Should have been 7.x. @driesvints @taylorotwell |
GrahamCampbell
pushed a commit
that referenced
this pull request
Mar 29, 2020
* fixed component class view reference * Update ComponentMakeCommand.php Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just an small fix here. So
php artisan make:component FormErrorworks so good straight out of the box. This PR however is aimed to fix the locating of theview(blade file) in the Component class for views that are kept inside subfolders in theviews/componentsfolder.When you run
php artisan make:component Errors/Sub1/FormErrorall the files are created in the right places but currently in theFormError@render()instead of
Currently you will have to visit the component class to make a fix.
Cheers