[5.7] Get table improvement #26488
Closed
[5.7] Get table improvement #26488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
Ah sorry, I'll check the closed PR's a little bit better the next time. Are there any tests that fail when this implementation is suggested? I tried the failed tests from travis-ci but they work locally. |
Contributor
|
It would be great if you could write such a test. |
Member
|
Yeah, this has caused problems in the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
getTablemethod is called multiple times, the method will make the table property from scratch every time. I don't think this is necessary. By setting the property in thegetTable()method when it doesn't exist yet, we can prevent that. I also added a test for this case.I am not sure if this could be a breaking change. For my projects it isn't. Feel free to close this PR if it is a breaking change.