[5.5] Fix NullSessionDriver due to upstream changes

[laurencei]

This is an attempt to fix #22302 that has started occuring due to upstream changes in the Symfony session (see the issue for a very good detailed explanation of the problem by @acarpio89).

The reason the changes only seems to affect the NullSessionDriver is because Laravel actually uses its own implementations of every other driver, and was only using the Symfony Null driver.

So this PR just creates our own Null driver, and we no longer rely on Symfony for it.

On a seperate issue - this is not picked up by any framework tests - because the tests all mock the session handler, and never try to actually create a session (from what I can see). I tried to create a failing test to capture this situation, but I cant work out how to do it inside a framework test?

Would be nice to add a test around this if someone can point me in the right direction.

[laurencei]

@taylorotwell - thanks for the quick merge.

Any idea how I can write a test around this? I cant seem to actually generate a session inside the test suite framework. It would be nice to write an integration test against the array driver or something?

[danijelk]

@laurencei Guess this is related here?

auth()->loginUsingId($widget->user_id);

Session name cannot be empty, did you forget to call "parent::open()" in "Symfony\Component\HttpFoundation\Session\Storage\Handler\NullSessionHandler"?.

Can't really find the culprit locally on my mac, this only happens in production after latest update.

• I have set the | Session Cookie Name in session.php
• Using redis as driver

Does one need to update to symfony 4.x?

[laurencei]

Are you running Laravel 5.5.24 or higher?

It doesnt really make much sense, because you are using the Redis driver. It should never call the Null handler.

[danijelk]

Indeed, was a symlink error in the project. After 5.5.24 update it works good, seems like only symfony was updated without this patch. Thanks for quick reply.