Skip to content

[5.5] Fix Data Missing for empty string date values #22108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2017
Merged

[5.5] Fix Data Missing for empty string date values #22108

merged 3 commits into from
Nov 17, 2017

Conversation

@VinceG
Copy link
Contributor

@VinceG VinceG commented Nov 16, 2017 •
edited
Loading

Fixes #22107

@VinceG VinceG changed the title #22107 Fix Data Missing for empty string date values Nov 16, 2017
@taylorotwell
Copy link
Member

taylorotwell commented Nov 16, 2017

It may make more sense to just check if empty

@VinceG
Copy link
Contributor Author

VinceG commented Nov 16, 2017 •
edited
Loading

@taylorotwell That's even better. Thank You.

@tillkruss tillkruss changed the title Fix Data Missing for empty string date values [5.5] Fix Data Missing for empty string date values Nov 17, 2017
@taylorotwell taylorotwell merged commit 9285f28 into laravel:5.5 Nov 17, 2017
@zagovorichev zagovorichev mentioned this pull request Nov 15, 2018
Closed
@VinceG VinceG deleted the fix-data-missing branch August 7, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VinceG @taylorotwell