[5.5] Fix eager loading HasManyThrough relations with custom intermediate and local key #21902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Whenever I try to eager load a hasManyThrough relation that uses a custom intermediate and a local key I get an empty collection.
This happens because when the
match(array $models, Collection $results, $relation)on theHasManyThroughclass is called, the relation is set using the$model->getKeyrather than my provided$this->localKeyattribute.Changing
into
fixes it because
$this->localKeydefaults to thepkanyway.Also, I think this is also a fix for this issue #15909 (haven't tested, but looks like the same problem)